[IMP] Client side code cleaning and Python extension integration #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvsola
changed the title
delvsola
force-pushed
the
master-migrate-to-python-extension-loha
branch
from
6845182
to
960903f
Compare
Louciole
force-pushed
the
master-migrate-to-python-extension-loha
branch
2 times, most recently
from
50ca72b
to
67034fc
Compare
Louciole
force-pushed
the
master-migrate-to-python-extension-loha
branch
2 times, most recently
from
7eeb0a3
to
f687c6d
Compare
Louciole
force-pushed
the
master-migrate-to-python-extension-loha
branch
from
842e676
to
2aa0c62
Compare
delvsola
commented
Jan 8, 2024
vscode/client/extension.ts
Outdated
| } | ||
|
|
||
| //trying to use the VScode python extension | ||
| if (interpreter && global.IS_PYTHON_EXTENSION_READY !== false) { | ||
| config ? pythonPath = interpreter.path[0] : pythonPath = null; |
There was a problem hiding this comment.
pythonPath = config ? interpreter.path[0] : null
|
@Louciole The extension crashes when starting as Disabled with the Python extension enabled |
I can't reproduce it (either in the debug or packaged version) did you do something special? |
Changes: - Remove pythonPath field from Config view - Integrate Python extension - Properly use async/await in the code. - Use of global.d.ts for Global variables. - Wait for LanguageClient to stop before starting it again - Queue Configuration change when LanguageClient is still stopping - Properly hide Crash notification test command in Production - outputChannel is now stored globally instead of being passed to all functions - Logging is now done through LanguageClient - Add a Bash shebang to build_package.sh Co-authored by Solan (sode)
… python extension Changes: - check if python extension is ready and save it in global - display python path in config when relevant - check and prepare the environment without python extension
The main goal of this commit is to be able not to set pythonPath when the extension is disabled
Louciole
force-pushed
the
master-migrate-to-python-extension-loha
branch
from
2aa0c62
to
9401ddd
Compare
/!\ there's probably still a bug on windows
fda-odoo
reviewed
Feb 5, 2024
| if (_api) { | ||
| return _api; | ||
| } | ||
| _api = await PythonExtension.api(); |
There was a problem hiding this comment.
are we sure it will never become invalid?
There was a problem hiding this comment.
We only use this Promise right after getting it and getting it each time we need it to be as close to the current configuration as we can be so there's no reason for it to be invalid in the current setup (but maybe I didn't understand the comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a first fix to many errors in the client code and acts as an intermediate patch until the client side is properly refactored.
The extension also now integrates VSCode's Python extension, which means the Language Server will now be launched with the Interpreter selected for that workspace.
Changes
Fixes