Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] runbot: remove useless pip warning #738

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

d-fence
Copy link
Contributor

@d-fence d-fence commented Mar 9, 2023

When pip installs a package that contains a script, it goes in ~/.local/bin directory of the current user. This leads to a log warning to warn the user that the script won't be accessible by other users.

e.g.:
WARNING: The script pygmentize is installed in '/home/odoo/.local/bin' which is not on PATH.

This is particularly annoying for documentation builds because it may confuse the users.

@C3POdoo C3POdoo requested a review from a team March 9, 2023 09:35
@AntoineVDV AntoineVDV removed their request for review March 9, 2023 09:37
@AntoineVDV
Copy link

👍

@d-fence
Copy link
Contributor Author

d-fence commented Mar 9, 2023

We may go for another solution that is to put the . local/bin in PATH instead.
Because we don't want the wrong script to be called.

When pip installs a package that contains a script, it goes in
`~/.local/bin` directory of the current user. This leads to a log warning
to warn the user that the script won't be accessible by other users.

e.g.:
`WARNING: The script pygmentize is installed in '/home/odoo/.local/bin'
which is not on PATH.`

This is particularly annoying for documentation builds because it may
confuse the users.

Also, it means that when a locally installed pip package overrides a
python package installed system wide (e.g.: by apt-get), it's still
globally script that runs when called.

With this commit, the user PATH is updated to include this local bin
directory when building Docker images.
@d-fence d-fence force-pushed the 15.0-runbot-pip-no-warn-moc branch from 7ee62d5 to 8b3b53b Compare March 9, 2023 13:29
@Xavier-Do Xavier-Do changed the base branch from 15.0 to 16.0 June 22, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants