[ADD] estate: Manage Your Properties, Maximize Your Returns #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneg-odoo
force-pushed
the
17.0-tranning-aneg
branch
7 times, most recently
from
374f472
to
818ba2b
Compare
-create new estate model -create offer for a property and relation between properties like one2Many , many2Many, many2One -create computed fields -create action fields and action buttons for sold & cancle and offer accept & refused -create views for property, type, tag and offer -create security for all the the above model
aneg-odoo
force-pushed
the
17.0-tranning-aneg
branch
from
818ba2b
to
ea4b032
Compare
adsh-odoo
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Hello @aneg-odoo
Some comments mostly regarding the guidelines.
Can you please check.
Thanks!!
| }), | ||
| ]" /> | ||
| </record> | ||
| </odoo> |
There was a problem hiding this comment.
Leave a blank line at the EOF
Make sure to check in other files also.
estate/models/estate_property.py
Outdated
Comment on lines
1
to
4
| from odoo import api, models, fields | ||
| from datetime import datetime | ||
| from dateutil.relativedelta import relativedelta | ||
| from odoo.exceptions import UserError, ValidationError |
There was a problem hiding this comment.
Suggested change
| from odoo import api, models, fields | |
| from datetime import datetime | |
| from dateutil.relativedelta import relativedelta | |
| from odoo.exceptions import UserError, ValidationError | |
| from datetime import datetime | |
| from dateutil.relativedelta import relativedelta | |
| from odoo import api, fields, models | |
| from odoo.exceptions import UserError, ValidationError |
Generally, we follow a convention in which we first import external libraries and then we make import from odoo in alphabetical order. Do same for other files also
estate/models/estate_property.py
Outdated
Comment on lines
108
to
112
| # def check_limit(self, vals): | ||
| # self.status = "offer received" | ||
|
|
||
| # if vals.get("price") <= self.best_price: | ||
| # raise ValidationError("the offer must be higher than best price") |
There was a problem hiding this comment.
Try to avoid pushing the commented code.
Comment on lines
+24
to
+31
| <div class="d-flex justify-content-end"> | ||
| <header> | ||
| <button name="%(estate.estate_property_offer_action)d" type="action" | ||
| class="oe_stat_button" | ||
| icon="fa-money" string="Offers"> | ||
| <field name="offer_count" string="Offer Count" /> | ||
| </button> | ||
| </header> | ||
| </div> |
There was a problem hiding this comment.
Suggested change
| <div class="d-flex justify-content-end"> | |
| <header> | |
| <button name="%(estate.estate_property_offer_action)d" type="action" | |
| class="oe_stat_button" | |
| icon="fa-money" string="Offers"> | |
| <field name="offer_count" string="Offer Count" /> | |
| </button> | |
| </header> | |
| </div> | |
| <div name="button_box"> | |
| <button class="oe_stat_button" type="action" name="%(estate.action_open_offer)d" | |
| icon="fa-ticket"> | |
| <field string="Offers" name="offer_count" widget="statinfo"/> | |
| </button> | |
| </div> |
You can do something like this for better alignment of stat button
| <filter string="group_by_postcode" name="postcode" | ||
| context="{'group_by' :'postcode'}" /> | ||
| </search> | ||
|
|
There was a problem hiding this comment.
Remove extra blank lines.
Check for other files also
…eatures (estate): add property offers report and sample data for testing - Created a new report for estate property offers (PDF format) - Added sample data for testing new estate property features - Fixed XML issues related to ir.actions.report and external ID conflicts
aneg-odoo
force-pushed
the
17.0-tranning-aneg
branch
from
76028e2
to
fa30f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-create new estate model
-create offer for a property and relation between properties like one2Many , many2Many, many2One
-create computed fields
-create action fields and action buttons for sold & cancle and offer accept & refused
-create views for property, type, tag and offer
-create security for all the the above model