[IMP] util/fields: update default when converting to html #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
diagnoza
force-pushed
the
master-update_html_default-owi
branch
from
cd5ce4c
to
e9d5416
Compare
KangOl
requested changes
Oct 25, 2024
src/util/fields.py
Outdated
Comment on lines
663
to
666
| SET json_value = REPLACE( | ||
| REPLACE(json_value, '\n', '<br/>'), | ||
| '\t', ' ' | ||
| ) |
src/util/fields.py
Outdated
| UPDATE ir_default AS d | ||
| SET json_value = REPLACE( | ||
| REPLACE(json_value, '\n', '<br/>'), | ||
| '\t', ' ' |
There was a problem hiding this comment.
This should be part of pg_text2html.
Instead of 4 spaces, we can use the   entity (em space, U+2003)
There was a problem hiding this comment.
we can use the
 entity
Or just 	.
diagnoza
force-pushed
the
master-update_html_default-owi
branch
2 times, most recently
from
1a8ffaa
to
595dd43
Compare
|
CI seems wrong to indicate a syntax error. |
|
You cannot use f-strings in the utils. It must be Python2 compatible. |
One could use Python escape sequences in text fields. When converting a field to HTML, they will no longer work, so replace them with HTML tags.
diagnoza
force-pushed
the
master-update_html_default-owi
branch
from
595dd43
to
84f0d0f
Compare
|
upgradeci retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One could use Python escape sequences in text fields. When converting a field to HTML, they will no longer work, so replace them with HTML tags.
Before:
After:
opw-4133947