Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] New option of grouping one_sale_one_purchase #1352

Open
wants to merge 5 commits into
base: 8.0
Choose a base branch
from

Conversation

drl9319
Copy link

@drl9319 drl9319 commented Mar 1, 2017

I create new option (One Sale, One Purchase) in procurement_purchase_no_groping to add new funcionality.
This funcionality make that: One sale order create only one purchase order for supllier with all related lines. This funcion make that only groping purchase order from de same sale order.

@drl9319 drl9319 changed the title New option of grouping one_sale_one_purchase [8.0] New option of grouping one_sale_one_purchase Mar 1, 2017
@rubencabrera
Copy link

+1
Works and solves a common problem, good one!

@anajuaristi
Copy link
Contributor

anajuaristi commented Mar 1, 2017 via email

@pedrobaeza
Copy link
Member

This module has been proposed now to be in OCA. Maybe you should propose there also the improvement after the merge. Anyway, Travis is red, so this is the first thing to fix.

@codecov-io
Copy link

codecov-io commented Mar 2, 2017

Codecov Report

Merging #1352 into 8.0 will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              8.0    #1352      +/-   ##
==========================================
+ Coverage   58.74%   58.76%   +0.02%     
==========================================
  Files         269      269              
  Lines        8075     8079       +4     
==========================================
+ Hits         4744     4748       +4     
  Misses       3331     3331
Impacted Files Coverage Δ
...nt_purchase_no_grouping/models/product_category.py 100% <ø> (ø)
...t_purchase_no_grouping/models/procurement_order.py 100% <ø> (ø)
...ment_purchase_no_grouping/models/purchase_order.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02141e...d9acf54. Read the comment docs.

'''
aux = args
aux.append(('origin', '=', context.get('origin', False)))
arg = aux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drl9319 is this correct? It seems to be a misspell

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an Error because arsg is a list an in Python if I assign list = list is by reference, for that this works ok. But I clean the code now.

@drl9319
Copy link
Author

drl9319 commented Mar 2, 2017

Now the error is for the function is in old api, but this module before has this funcion (in old api) and was be in the master branch

@drl9319
Copy link
Author

drl9319 commented Mar 13, 2017

What happens with the pull request?

@carlosap92
Copy link

It works fine! +1

@pedrobaeza
Copy link
Member

Again, it's better to move the efforts to OCA instead here: OCA/purchase-workflow#343

@jesuspablo
Copy link

+1
good job..

@anajuaristi
Copy link
Contributor

Travis failed so we can't merge until error is solved.
Sorry but we are quite strict on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants