-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] New option of grouping one_sale_one_purchase #1352
base: 8.0
Are you sure you want to change the base?
Conversation
+1 |
This module has been proposed now to be in OCA. Maybe you should propose there also the improvement after the merge. Anyway, Travis is red, so this is the first thing to fix. |
Codecov Report
@@ Coverage Diff @@
## 8.0 #1352 +/- ##
==========================================
+ Coverage 58.74% 58.76% +0.02%
==========================================
Files 269 269
Lines 8075 8079 +4
==========================================
+ Hits 4744 4748 +4
Misses 3331 3331
Continue to review full report at Codecov.
|
''' | ||
aux = args | ||
aux.append(('origin', '=', context.get('origin', False))) | ||
arg = aux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drl9319 is this correct? It seems to be a misspell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an Error because arsg is a list an in Python if I assign list = list is by reference, for that this works ok. But I clean the code now.
Now the error is for the function is in old api, but this module before has this funcion (in old api) and was be in the master branch |
What happens with the pull request? |
It works fine! +1 |
Again, it's better to move the efforts to OCA instead here: OCA/purchase-workflow#343 |
+1 |
Travis failed so we can't merge until error is solved. |
I create new option (One Sale, One Purchase) in procurement_purchase_no_groping to add new funcionality.
This funcionality make that: One sale order create only one purchase order for supllier with all related lines. This funcion make that only groping purchase order from de same sale order.