Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrp product variants #1387

Open
wants to merge 9 commits into
base: 8.0
Choose a base branch
from
Open

Conversation

mikelarre
Copy link
Contributor

[FIX] mrp_product_variants: Solved the problem of uom loss by changing quantity of product

@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #1387 into 8.0 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              8.0    #1387      +/-   ##
==========================================
+ Coverage   61.73%   61.74%   +<.01%     
==========================================
  Files         284      284              
  Lines        8561     8563       +2     
==========================================
+ Hits         5285     5287       +2     
  Misses       3276     3276
Impacted Files Coverage Δ
mrp_product_variants/models/mrp_production.py 59.09% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f245d4e...c3003a3. Read the comment docs.

Copy link
Contributor

@alfredoavanzosc alfredoavanzosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@@ -27,6 +27,8 @@ def onchange_product_qty(self, product_id, product_qty):
res = self.product_id_change(product_id, product_qty=product_qty)
if res['value'].get('product_attribute_ids'):
del res['value']['product_attribute_ids']
if 'product_uom' in res['value']:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    if not res['value'].get('product_uom', True):

only delete value if it is False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants