Extend --autoCreation effect (or default lack thereof) to newly appearing sub-datasets
#636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_N_valid status and its relation to autoCreation mode Signed-off-by: Jim Klimov <[email protected]>
…f (recursively processed) destinations also Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…CLI option ...to help override a --autoCreation setting from /etc/defaults/znapzend et al. Signed-off-by: Jim Klimov <[email protected]>
…ation option Signed-off-by: Jim Klimov <[email protected]>
oetiker
previously approved these changes
Mar 11, 2024
|
I think the zfs aproach #637 is sensible ... do you see benefit in this still ? |
|
Somewhat yes. Properties allow for default settings, CLI options for run-time decisions. And this PR allows the latter to be consistent when nested datasets are involved :) |
oetiker
approved these changes
Apr 25, 2024
oetiker
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, avoid unexpected creation of avoidably large replicas of root datasets where promotable clones of boot environments are used (currently
znapzendmakes a new fullzfs send, not a clone+promote operation - see #503 and others after it).Also added a
--noautoCreationoption to help override configuration file settings (where used), primarily to help test this change locally.NOTE: I have a nagging feeling that the default value for this setting belongs in ZFS properties (per-destination) rather than in CLI as one toggle to rule them all (can be kept for one-off overrides). Maybe another PR would address that, more so if I get to solving #503 directly. UPDATE: See #637 for zfs props approach.