Set default permission class to IsAuthenticated & made required changes #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set permissions to [] on required public endpoints removed explicit permission attribute if it IsAuthenticated only Fixes ohcnetwork#2238
|
@sainak Can you have a look at this PR? |
|
@sainak Functional review required. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2268 +/- ##
===========================================
- Coverage 65.62% 65.49% -0.14%
===========================================
Files 222 222
Lines 13319 13267 -52
Branches 1882 1882
===========================================
- Hits 8741 8689 -52
- Misses 4190 4191 +1
+ Partials 388 387 -1 ☔ View full report in Codecov by Sentry. |
sainak
force-pushed
the
fix-issue-2238
branch
from
d5d314e
to
d7e0441
Compare
sainak
approved these changes
Sep 23, 2024
vigneshhari
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2238
Proposed Changes
Associated Issue
Architecture changes
Merge Checklist
/docs@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins