Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Diagnosis at Discharge field when patient is discharged #8390

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Added Diagnosis at Discharge field when patient is discharged #8390

wants to merge 14 commits into from

Conversation

JOSHIK27
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@JOSHIK27 JOSHIK27 requested a review from a team as a code owner August 22, 2024 07:27
@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024

@JOSHIK27 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 755c4bc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c6fb6d41c7240008c820b2
😎 Deploy Preview https://deploy-preview-8390--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JOSHIK27 JOSHIK27 mentioned this pull request Aug 22, 2024
Open
4 tasks
rithviknishad
rithviknishad requested changes Aug 22, 2024
View reviewed changes
src/Components/Facility/DischargeModal.tsx Outdated Show resolved Hide resolved
src/Components/Facility/DischargeModal.tsx Outdated Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 627d02e
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66c6f1668fbd1e00081bee4e

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 9f2f9d6
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66c6f17c05be5a00080491d2

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Aug 22, 2024
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Aug 22, 2024
@samholics
Copy link

can we rename the "Diagnoses" to "Diagnosis at Discharge" pls?
image

@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024 •
edited
Loading

👷 Deploy request for care-ohc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5cfccce

@rithviknishad
Copy link
Member

can we rename the "Diagnoses" to "Diagnosis at Discharge" pls?

@samholics Done

@samholics
Copy link

Tested working fine @rithviknishad @nihal467

@nihal467
Copy link
Member

nihal467 commented Sep 2, 2024 •
edited
Loading

@JOSHIK27

image

  • When we open an active consultation page, it is throwing not found an error with 404
  • the cypress was failing as well, verify the test is also passing

CC: @rithviknishad

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

👋 Hi, @JOSHIK27,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 3, 2024
@nihal467
Copy link
Member

nihal467 commented Sep 6, 2024

@JOSHIK27 are you still working on this issue ?

@JOSHIK27
Copy link
Contributor Author

JOSHIK27 commented Sep 6, 2024

@JOSHIK27 are you still working on this issue ?

Yes. I am

@nihal467
Copy link
Member

nihal467 commented Sep 9, 2024

@JOSHIK27 once the PR is ready for review, drop a comment

@JOSHIK27
Copy link
Contributor Author

JOSHIK27 commented Sep 9, 2024

@JOSHIK27 once the PR is ready for review, drop a comment

When i ran cypress tests by running docker container locally with loaded dummy data on develop branch(as per readme of backend), bunch of tests failed which shouldn't happen. @nihal467 Am i missing something ?
image

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 10, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @JOSHIK27,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 10, 2024
@github-actions github-actions bot added the stale label Sep 18, 2024
@nihal467 nihal467 self-assigned this Sep 18, 2024
@nihal467 nihal467 removed test failed merge conflict pull requests with merge conflict labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivankacker shivankacker shivankacker approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

Assignees

@nihal467 nihal467

Labels
needs review needs testing stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discharge diagnosis
5 participants
@JOSHIK27 @samholics @rithviknishad @nihal467 @shivankacker