Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated blood pressure range #8498

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Updated blood pressure range #8498

wants to merge 7 commits into from

Conversation

rithviknishad
Copy link
Member

Required Backends

Proposed Changes

image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner September 6, 2024 13:39
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 585b645
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66e51ce5e5c0d50008aeef9c
😎 Deploy Preview https://deploy-preview-8498--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad changed the title Added support to have optionally restrictive range for RangeFormField's slider Support for specifying blood pressure as "non measurable" and skip sending mean arterial pressure Sep 6, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 6, 2024 •
edited
Loading

CARE    Run #3344

Run Properties:  status check passed Passed #3344  •  git commit 585b645d35: Updated blood pressure range
Project CARE
Branch Review rithviknishad/fix/blood-pressure-range-and-recordable
Run status status check passed Passed #3344
Run duration 02m 58s
Commit git commit 585b645d35: Updated blood pressure range
Committer Rithvik Nishad
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 128
View all changes introduced in this branch ↗︎

@bodhish
Copy link
Member

bodhish commented Sep 6, 2024

@rithviknishad the ux assumes that not measurable is a very common scenario; do we need it? How valuable is not measurable information? Can't that be part of the notes?

CC: @gigincg @aparnacoronasafe

@aparnacoronasafe
Copy link
Member

The layout of the short vitals form (with text box and not slider) looks very bad.

Can we have "Not measurable" come below the text field?

The text spaces for systolic and diastolic must come together as "____/_____"- having the checkbox come in between the field is not ideal.

@aparnacoronasafe
Copy link
Member

@rithviknishad the ux assumes that not measurable is a very common scenario; do we need it? How valuable is not measurable information? Can't that be part of the notes?

CC: @gigincg @aparnacoronasafe

"Not measurable" is not a very common scenario. design to be improved to have the option come up below BP fields, not above

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 10, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad changed the title Support for specifying blood pressure as "non measurable" and skip sending mean arterial pressure Updated blood pressure range Sep 10, 2024
@nihal467
Copy link
Member

nihal467 commented Sep 13, 2024 •
edited by rithviknishad
Loading

@rithviknishad
image

  • when you click on the vital section, the entire page crashes

@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 18, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

@shivankacker shivankacker Awaiting requested review from shivankacker

@khavinshankar khavinshankar Awaiting requested review from khavinshankar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict needs review tested waiting for backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update range of diastolic blood pressure in detailed log update
4 participants
@rithviknishad @bodhish @aparnacoronasafe @nihal467