Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable features from backend feature flags #8512

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Sep 9, 2024

Proposed Changes

  • Fixes Use the new feature flag API for scribe #8505
  • Adds a useFeatureFlags hook for getting facility and user features from the backend.
  • HCX and ABDM can be enabled this way, but only scribe is supported as of yet
  • NOTE: Flags are cached, and will take time to update. Please execute redis-cli flushall when you test it to clear cache.

What changed

  • nothing on the user end
  • scribe can now be only enabled by passing the "SCRIBE_ENABLED" flag on the backend admin panel as a user flag or a facility flag. (The button for scribe on daily rounds page will be shown)
  • if a user has scribe enabled, they can use it in any facility. If it is enabled on the facility, it can be used in that facility only.

To add flags you need to first use a backend that runs the scribe plug pulled from my PR (mentioned above)

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner September 9, 2024 13:34
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 77501c4
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/66fa9bb0611b3b0008165d9f
😎 Deploy Preview https://deploy-preview-8512--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Sep 9, 2024

CARE    Run #3491

Run Properties:  status check passed Passed #3491  •  git commit 77501c4e64: Enable features from backend feature flags
Project CARE
Branch Review facility-features
Run status status check passed Passed #3491
Run duration 03m 16s
Commit git commit 77501c4e64: Enable features from backend feature flags
Committer Shivank Kacker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 124
View all changes introduced in this branch ↗︎

@shivankacker shivankacker self-assigned this Sep 9, 2024
Copy link

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 17, 2024
@github-actions github-actions bot added Deploy-Failed Deplyment is not showing preview and removed merge conflict pull requests with merge conflict labels Sep 20, 2024
@sainak sainak removed waiting for backend Deploy-Failed Deplyment is not showing preview labels Sep 20, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 23, 2024
Copy link

👋 Hi, @shivankacker,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@shivankacker can you add more description in the PR for review purposes, what changed, and where all in the platform it will be effected

@nihal467 nihal467 added the question Further information is requested label Sep 24, 2024
@shivankacker
Copy link
Member Author

@nihal467 added some more info to the description.

@shivankacker shivankacker removed the question Further information is requested label Sep 24, 2024
@nihal467 nihal467 added waiting for related PR a co-related detail PR is under construction and removed waiting for related PR a co-related detail PR is under construction labels Sep 27, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 77501c4
Status: ✅  Deploy successful!
Preview URL: https://81506bab.care-fe.pages.dev
Branch Preview URL: https://facility-features.care-fe.pages.dev

View logs

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 30, 2024
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar added the question Further information is requested label Oct 1, 2024
@rithviknishad rithviknishad removed the question Further information is requested label Oct 2, 2024
@khavinshankar khavinshankar merged commit cf8f87b into develop Oct 3, 2024
30 checks passed
@khavinshankar khavinshankar deleted the facility-features branch October 3, 2024 02:46
Copy link

github-actions bot commented Oct 3, 2024

@shivankacker @shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new feature flag API for scribe
6 participants