Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support protected and unprotected urls #218

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Support protected and unprotected urls #218

wants to merge 3 commits into from

Conversation

cs1m0n
Copy link

@cs1m0n cs1m0n commented Sep 7, 2020

No description provided.

@timnolte
Copy link
Collaborator

timnolte commented Sep 7, 2020

@daggerhart I'll take a look through this tonight. It's apparent that a composer install wasn't performed before these changes were made as GrumPHP wouldn't have let this commit happen since it wouldn't pass static analysis checks. I'd really like to get Travis CI setup with the repo so that PRs would automatically be checked and can show when checks fail.

@timnolte timnolte self-assigned this Sep 7, 2020
@timnolte timnolte added enhancement Issues & PRs related to new features. status: needs review PR that needs review. status: needs changelog Mark all PRs that have not had their changelog entries added. status: needs docs Needs explanation in release notes, README, or documentation. labels Sep 7, 2020
@timnolte timnolte self-requested a review September 7, 2020 18:55
@timnolte
Copy link
Collaborator

@cs1m0n this PR is failing both WordPress coding standards. You can run these check with NPM if you have the local development environment setup.

@timnolte timnolte deleted the branch oidc-wp:develop December 23, 2023 00:56
@timnolte timnolte closed this Dec 23, 2023
@timnolte timnolte reopened this Dec 23, 2023
@timnolte timnolte changed the base branch from dev to develop December 23, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timnolte timnolte Awaiting requested review from timnolte timnolte is a code owner

@daggerhart daggerhart Awaiting requested review from daggerhart daggerhart is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@timnolte timnolte

Labels
enhancement Issues & PRs related to new features. status: needs changelog Mark all PRs that have not had their changelog entries added. status: needs docs Needs explanation in release notes, README, or documentation. status: needs review PR that needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cs1m0n @timnolte