feat: Oracle vote extension handler #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 16.06% 16.91% +0.84%
==========================================
Files 78 82 +4
Lines 18781 19092 +311
==========================================
+ Hits 3018 3230 +212
- Misses 15596 15674 +78
- Partials 167 188 +21 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -169,7 +170,7 @@ | |||
| // EndBlock executes all ABCI EndBlock logic respective to the x/oracle module. | |||
| // It returns no validator updates. | |||
| func (am AppModule) EndBlock(ctx context.Context) ([]abci.ValidatorUpdate, error) { | |||
| if err := EndBlocker(ctx, am.keeper); err != nil { | |||
| if err := oracleabci.EndBlocker(ctx, am.keeper); err != nil { | |||
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
|
Dependency issues will be resolved by merging https://github.com/ojo-network/ojo/pull/405/files |
adamewozniak
reviewed
Apr 4, 2024
adamewozniak
reviewed
Apr 9, 2024
Co-authored-by: Adam Wozniak <[email protected]>
Co-authored-by: Adam Wozniak <[email protected]>
Co-authored-by: Adam Wozniak <[email protected]>
adamewozniak
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...