Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v0.3.2 upgrade handler #481

Merged
merged 4 commits into from
Jul 26, 2024
Merged

chore: v0.3.2 upgrade handler #481

merged 4 commits into from
Jul 26, 2024

Conversation

rbajollari
Copy link
Collaborator

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner July 19, 2024 09:37
rbajollari added a commit that referenced this pull request Jul 19, 2024
Copy link
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a test for the conversion function

app/upgrades.go Outdated Show resolved Hide resolved
@rbajollari rbajollari added S:backport/v0.3.x Backports to the release/v0.3.x branch and removed S:backport/v0.3.x Backports to the release/v0.3.x branch labels Jul 25, 2024
@rbajollari
Copy link
Collaborator Author

@Mergifyio backport release/v0.3.x

Copy link
Contributor

mergify bot commented Jul 25, 2024

backport release/v0.3.x

✅ Backports have been created

@rbajollari rbajollari merged commit faac055 into main Jul 26, 2024
24 of 25 checks passed
@rbajollari rbajollari deleted the ryan/v0.3.2-handler branch July 26, 2024 09:22
mergify bot pushed a commit that referenced this pull request Jul 26, 2024
* chore: v0.3.2 upgrade handler

* convert proposals

* lint

* migrate proposal test

(cherry picked from commit faac055)

# Conflicts:
#	app/upgrades.go
adamewozniak pushed a commit that referenced this pull request Jul 29, 2024
* chore: v0.3.2 upgrade handler (#481)

* chore: v0.3.2 upgrade handler

* convert proposals

* lint

* migrate proposal test

(cherry picked from commit faac055)

# Conflicts:
#	app/upgrades.go

* fix conflicts

* new pf version in e2w

---------

Co-authored-by: ryanbajollari <[email protected]>
Co-authored-by: rbajollari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants