Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relay to EVM via ABCI #525

Merged
merged 23 commits into from
Oct 2, 2024
Merged

feat: relay to EVM via ABCI #525

merged 23 commits into from
Oct 2, 2024

Conversation

adamewozniak
Copy link
Member

@adamewozniak adamewozniak commented Sep 29, 2024

Description

A few significant features:

  • Users can use the x/gmp/createPayment msg to create a payment to periodically push updates to Axelar Contracts
  • The x/gmp module's endblocker will push updates for each payment until they run out of funds
  • A new x/gas_estimation module, which has parameters and a KV store that the oracle module & gmp module can access without running into circular dependencies
  • Updates to the x/oracle/abci package to also use ABCI++ to calculate gas estimation and set it in the KV store

Other updates:

  • go version update to v0.23

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@adamewozniak
Copy link
Member Author

adamewozniak commented Sep 30, 2024

This is pretty much ready for review, I just need to update e2e, liveness, and the abci test suite to be compatible with the new logic / module. We need to have a careful eye here:

  • x/oracle/abci/proposal.go
  • x/oracle/abci/voteextension.go
  • x/gmp/module.go Endblock
  • x/gmp/keeper/keeper.go ProcessPayment

@adamewozniak adamewozniak marked this pull request as ready for review September 30, 2024 21:24
@adamewozniak adamewozniak requested a review from a team as a code owner September 30, 2024 21:24
Copy link
Collaborator

@rbajollari rbajollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update this method:

func buildLocalCommitInfo(
to add gas estimates in the vote extension so that the Proposal unit tests can pass

proto/ojo/gasestimate/v1/gasestimate.proto Outdated Show resolved Hide resolved
x/oracle/abci/proposal.go Outdated Show resolved Hide resolved
x/gmp/module.go Outdated Show resolved Hide resolved
@adamewozniak adamewozniak merged commit b16218c into main Oct 2, 2024
25 of 26 checks passed
@adamewozniak adamewozniak deleted the woz/relays-abci branch October 2, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants