Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate data and metadata editing logic #494

Open
roll opened this issue Aug 9, 2024 · 0 comments
Open

Separate data and metadata editing logic #494

roll opened this issue Aug 9, 2024 · 0 comments

Comments

@roll
Copy link
Collaborator

roll commented Aug 9, 2024

Overview

Initially, Open Data Editor was meant to be an IDE so it made sense to have panel based Metadata editor with an ability to simultaneously see and edit the data and metadata. As of now it is more of a simple tabular data validator, there is no reason to keep this complexity.

Currently, the most problematic parts are:

  • patch logic on the server where there are endpoints that expect both data and metadata updates in the same call
  • some client logic in the store that is overcomplicated because it needs to keep track of both data and metadata editing state

The simplest solution would be to rebase metadata editing on a dialog with separate "Save/Close" logic and keep only data editing in the main mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant