Fixed metadata editing

[roll]

• fixes Error when editing the schema of the resource #467

[cloudflare-workers-and-pages]

Deploying opendataeditor with    Cloudflare Pages

Latest commit:	a1ef385
Status:	✅  Deploy successful!
Preview URL:	https://ce807ca0.opendataeditor.pages.dev
Branch Preview URL:	https://467-fix-schema-editing.opendataeditor.pages.dev

View logs

[pdelboca]

@roll I'm still seeing the error when running this branch.

Check out the steps on how I reproduce the error:

simplescreenrecorder-2024-08-10_13.18.17.webm

[roll]

@pdelboca
Do you use the same file that you uploaded before the fix? It might be in a broken state already. Can you please try from scratch?

[pdelboca]

@roll it happens with all new files. See attached video on how to replicate the error

simplescreenrecorder-2024-08-12_13.46.39.webm

[roll]

@pdelboca
Thanks, I can reproduce it. It works as expected unless we delete some text in metadata editor. When it deletes the text it issues delete-multiple-cells table event for some reason (cc @guergana). I'm going to investigate and fix it

[guergana]

delete-multiple-cells

  // works automatically, doesnt need to be passed to <TableEditor with onKeyPress
  useKeyPress(['delete', 'backspace'], () => {
    store.deleteMultipleCells(cellSelection)
  })

the keypress event seems to be activated outside the table editor 🙈 @roll

[roll]

No problem @guergana, I'm quick fixing this just by checking if there is an actual cell selection (later will be even safer after #494)

[roll]

@pdelboca
Can you please test it again?

[romicolman]

Hi all!

I tested the implementation for issue #467 and it works OK on Mac. However, I could not test the change for #490.

[roll]

Hi @romicolman,

The hover on errors returned for me after the changes in this PR (although I wasn't trying to fix it deliberately)

[romicolman]

It works on Mac!

[roll]

Thanks!