Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt dialogs to the new UI #526

Open
romicolman opened this issue Aug 26, 2024 · 2 comments · May be fixed by #556
Open

Adapt dialogs to the new UI #526

romicolman opened this issue Aug 26, 2024 · 2 comments · May be fixed by #556
Assignees

Comments

@romicolman
Copy link
Collaborator

Description

We need to adapt current dialogs from the ODE to the new UI.

For instance: once the context menu is implemented, when the user clicks on delete, the ODE should display this message (dialog updated to new UI):

Captura de pantalla 2024-08-26 a la(s) 9 13 43 a  m

Check Figma file here.

@guergana
Copy link
Collaborator

guergana commented Sep 22, 2024

@Faithkenny @romicolman I see inconsistencies in the design...

First we don't have a way of renaming folders... so this dialog we dont have to implement for now I guess?

then... why is the closing action different for the Create folder and Delete file dialogs? create folder has a close icon on the top right corner, delete doesn't have it and has a cancel button instead.

As @pdelboca suggested.. we should strive for some uniformity in the dialogs, maybe a couple of changes. like the button color, but having completely different dialogs for each case is not ideal.

@guergana
Copy link
Collaborator

@Faithkenny @romicolman the "Publish" dialog is missing from the Figma design:

image

@guergana guergana linked a pull request Sep 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: On hold
Development

Successfully merging a pull request may close this issue.

3 participants