-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt dialogs to new design #556
Conversation
Deploying opendataeditor with Cloudflare Pages
|
8549cfe
to
5fa8272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Faithkenny I can't find the design for the disabled state of the buttons. It needs to have a higher contrast as @roll suggests... could you point me to the design? 🙏 |
5fa8272
to
723cc4b
Compare
@Faithkenny thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
To avoid making this PR larger than it is, I will create another PR to address the hover colors of buttons across the app and the dialogs, and another PR speficically for the 'Publish' dialog.