Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt dialogs to new design #556

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Adapt dialogs to new design #556

merged 5 commits into from
Oct 21, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Sep 22, 2024

To avoid making this PR larger than it is, I will create another PR to address the hover colors of buttons across the app and the dialogs, and another PR speficically for the 'Publish' dialog.

Copy link

cloudflare-workers-and-pages bot commented Oct 13, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6933754
Status: ✅  Deploy successful!
Preview URL: https://f55b616f.opendataeditor.pages.dev
Branch Preview URL: https://526-adapt-dialogs.opendataeditor.pages.dev

View logs

@guergana guergana changed the title [WiP] Adapt dialogs to new design Adapt dialogs to new design Oct 13, 2024
@guergana guergana changed the title Adapt dialogs to new design [WiP] Adapt dialogs to new design Oct 13, 2024
@guergana guergana changed the title [WiP] Adapt dialogs to new design Adapt dialogs to new design Oct 15, 2024
Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks good in general!

The disabled state looks quite weird for me. Is it intended?

ode

Also, just a note, that some text font/Cancel font would probably fail accessibility tests

client/components/Parts/Dialogs/OneButton.tsx Outdated Show resolved Hide resolved
client/components/Parts/Dialogs/TwoButton.tsx Outdated Show resolved Hide resolved
@guergana
Copy link
Collaborator Author

Thanks!

Looks good in general!

The disabled state looks quite weird for me. Is it intended?

ode

Also, just a note, that some text font/Cancel font would probably fail accessibility tests

@Faithkenny I can't find the design for the disabled state of the buttons. It needs to have a higher contrast as @roll suggests... could you point me to the design? 🙏

@Faithkenny
Copy link
Collaborator

Hey folks, Thank you for pointing that out. I've updated the foreground color (text), now it passess the accessibility checker. @roll. Consequently updates on the:

  • Add external file modal
  • Create folder modal

Here's the button @guergana:

image

@guergana
Copy link
Collaborator Author

Hey folks, Thank you for pointing that out. I've updated the foreground color (text), now it passess the accessibility checker. @roll. Consequently updates on the:

  • Add external file modal
  • Create folder modal

Here's the button @guergana:

image

@Faithkenny thanks!

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@guergana guergana merged commit c66ccaf into main Oct 21, 2024
9 checks passed
@guergana guergana deleted the 526-adapt-dialogs branch October 21, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt dialogs to the new UI
4 participants