Fixed field name editing

[roll]

• fixes ODE stops working when editing column names #562

---

Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

[cloudflare-workers-and-pages]

Deploying opendataeditor with    Cloudflare Pages

Latest commit:	55a1a80
Status:	✅  Deploy successful!
Preview URL:	https://174a857a.opendataeditor.pages.dev
Branch Preview URL:	https://562-fix-editing-column-names.opendataeditor.pages.dev

View logs

[guergana]

Great job, @roll , it works now but shouldn't this change include also updating the name of the column to reflect the empty column name? with this fix now an error shows but the column name looks the same in the tabular representation, so it's kinda hard to see what is the error:

[roll]

Thanks @guergana!

It's there it just needs better UI and error message:

PS.
Also, created this issue - #571

[romicolman]

Hi @roll and @guergana! I tested this PR.

The implementation works. In this sense, the ODE does not crash when changing the column name. However, if I go to the metadata panel, Schema--Fields and change the name of the column, the info is not updated. Should I create a separate issue for this @roll so we can merge this PR?

Video showing the problem:

Grabacion.de.pantalla.2024-09-27.a.la.s.2.53.11.p.m.mov

[roll]

@romicolman
Thanks!

Yes, let's create a separate issue because current behaviour is correct regarding the initial concept of how data and metadata editing co-exist. In this case:

• you edit metadata but not data so the field name now is "new_name"
• but data is not changed so it show a validation error

Probably we need to change it concept. Also I created this issue - #571

[guergana]

Thanks! ✔️

[romicolman]

New issue created :) #574

[roll]

Thanks!