Refactor Node executors for reusing environment variables

okode · May 10, 2020 · 26c1b42 · 26c1b42
1 parent 697fa51
commit 26c1b42
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/common/orb.yml b/common/orb.yml
@@ -10,6 +10,9 @@ cache-key-npm: &cache-key-npm
 cache-key-sonar: &cache-key-sonar
   key: cache-sonar-{{ .Environment.CIRCLE_JOB }}-{{ .Environment.CIRCLE_BRANCH }}-{{ checksum "sonar-project.properties" }}
 
+node-options: &node-options
+  NODE_OPTIONS: --max_old_space_size=6144
+
 orbs:
   aws-cli: circleci/[email protected]
 
@@ -21,6 +24,17 @@ executors:
         default: '14.2'
     docker:
       - image: cimg/node:<< parameters.node-version >>
+    environment:
+      << : *node-options
+  node-browsers:
+    parameters:
+      node-version:
+        type: string
+        default: '14'
+    docker:
+      - image: circleci/node:<< parameters.node-version >>-browsers
+    environment:
+      << : *node-options
   java:
     docker:
       - image: cimg/openjdk:11.0-node

diff --git a/ionic/orb.yml b/ionic/orb.yml
@@ -39,8 +39,9 @@ jobs:
         description: Deprecated
         type: string
         default: 'deprecated'
-    docker:
-      - image: circleci/node:<< parameters.node-version >>-browsers
+    executor:
+      name: common/node-browsers
+      node-version: << parameters.node-version >>
     steps:
       - run:
           name: Checking deprecated parameters
@@ -122,8 +123,6 @@ jobs:
         description: Deprecated
         type: string
         default: 'deprecated'
-    environment:
-      NODE_OPTIONS: --max_old_space_size=6144
     executor:
       name: common/node
       node-version: << parameters.node-version >>