Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inactivity_period default value from app_signon_policy_rule #2070

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove inactivity_period default value from app_signon_policy_rule #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58bc4ea
Update test assertion for inactivity_period default
reinoudk Aug 20, 2024
ff186b7
Remove default value for inactivity_period
reinoudk Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion okta/resource_okta_app_signon_policy_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ The only difference is that these fields are immutable and can not be managed: '
Type: schema.TypeString,
Optional: true,
Description: "The inactivity duration after which the end user must re-authenticate. Use the ISO 8601 Period format for recurring time intervals.",
Default: "PT1H",
},
"constraints": {
Type: schema.TypeList,
Expand Down
2 changes: 1 addition & 1 deletion okta/resource_okta_app_signon_policy_rule_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func TestAccResourceOktaAppSignOnPolicyRule(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "network_connection", "ANYWHERE"),
resource.TestCheckResourceAttr(resourceName, "constraints.#", "0"),
resource.TestCheckResourceAttr(resourceName, "re_authentication_frequency", "PT2H"),
resource.TestCheckResourceAttr(resourceName, "inactivity_period", "PT1H"),
resource.TestCheckNoResourceAttr(resourceName, "inactivity_period"),
resource.TestCheckResourceAttr(resourceName, "risk_score", "LOW"),
),
},
Expand Down