Fix sms authentication, by checking verifyResponse #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first response for sms authentication doesn't have the session_token in the response. Handle this case by testing for the SESSION_TOKEN in the response before reading it. Co-Authored-By: [email protected] Signed-off-by: Anuj Varma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first response for sms authentication doesn't have the session_token
in the response. Handle this case by testing for the SESSION_TOKEN in
the response before reading it.
Co-Authored-By: [email protected]
Signed-off-by: Anuj Varma [email protected]
Problem Statement
#382
#349
Solution
Handle the case by testing for the SESSION_TOKEN in
the response before reading it in the case of sms token where the reponse for verify removed the session_token.
https://developer.okta.com/docs/reference/api/authn/#verify-sms-factor