Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change val's consensus pubkey #3312

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

change val's consensus pubkey #3312

wants to merge 15 commits into from

Conversation

ylsGit
Copy link
Contributor

@ylsGit ylsGit commented Jul 7, 2024

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

BananaLF
BananaLF reviewed Jul 8, 2024
View reviewed changes
x/staking/handler.go Outdated
description, err := validator.Description.UpdateDescription(msg.Description)
if err != nil {
return nil, err
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest add height to upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BananaLF BananaLF BananaLF left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ylsGit @BananaLF