Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread to PushData2Database #125

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

thread to PushData2Database #125

wants to merge 7 commits into from

Conversation

chengzhinei
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #125 (2d4ffc7) into dev (f81bf43) will decrease coverage by 4.39%.
The diff coverage is n/a.

❗ Current head 2d4ffc7 differs from pull request most recent head 47d73e6. Consider uploading reports for the commit 47d73e6 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #125      +/-   ##
==========================================
- Coverage   34.53%   30.15%   -4.39%     
==========================================
  Files         429       54     -375     
  Lines       44774     5751   -39023     
==========================================
- Hits        15464     1734   -13730     
+ Misses      28162     3840   -24322     
+ Partials     1148      177     -971     

see 375 files with indirect coverage changes

@chengzhinei chengzhinei marked this pull request as draft May 15, 2023 08:26
@chengzhinei chengzhinei closed this Jun 1, 2023
@chengzhinei chengzhinei reopened this Jun 12, 2023
@chengzhinei chengzhinei marked this pull request as ready for review June 16, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants