Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proposal for modify the MaxGasUsedPerBlock #209

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

lyh169
Copy link
Contributor

@lyh169 lyh169 commented Aug 17, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #209 (a02d44c) into dev (e6ed0b9) will decrease coverage by 0.01%.
The diff coverage is 23.80%.

❗ Current head a02d44c differs from pull request most recent head 22137b0. Consider uploading reports for the commit 22137b0 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #209      +/-   ##
==========================================
- Coverage   34.45%   34.44%   -0.01%     
==========================================
  Files         430      431       +1     
  Lines       44883    44925      +42     
==========================================
+ Hits        15464    15476      +12     
- Misses      28271    28301      +30     
  Partials     1148     1148              
Files Changed Coverage Δ
app/config/config.go 26.74% <0.00%> (-0.17%) ⬇️
x/params/querier.go 0.00% <0.00%> (ø)
x/params/types/params.go 0.00% <0.00%> (ø)
x/params/types/params_block.go 0.00% <0.00%> (ø)
app/app.go 80.89% <50.00%> (-0.26%) ⬇️
x/params/keeper.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

zjg555543
zjg555543 previously approved these changes Aug 21, 2023
@KamiD KamiD merged commit cecd23d into dev Aug 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants