perf: use ${var##} instead of basename 🎛️

no subprocess fork, faster
oldratlee · Jan 29, 2024 · bdd10c5 · bdd10c5
1 parent 20520c1
commit bdd10c5
Show file tree

Hide file tree

Showing 14 changed files with 15 additions and 40 deletions.
diff --git a/bin/a2l b/bin/a2l
@@ -10,9 +10,7 @@
 # @author Jerry Lee (oldratlee at gmail dot com)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/ap b/bin/ap
@@ -12,9 +12,7 @@
 # @author Jerry Lee (oldratlee at gmail dot com)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/c b/bin/c
@@ -26,9 +26,7 @@
 #           var2=$(echo value1)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/coat b/bin/coat
@@ -11,9 +11,7 @@
 # @author Jerry Lee (oldratlee at gmail dot com)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/cp-into-docker-run b/bin/cp-into-docker-run
@@ -9,8 +9,7 @@
 # @author Jerry Lee (oldratlee at gmail dot com)
 set -eEuo pipefail
 
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################
@@ -207,8 +206,7 @@ if [ ! -f "$specified_run_command" ]; then
   run_command=$(which "$specified_run_command")
 fi
 run_command=$(portableReadLink "$run_command")
-run_command_base_name=$(basename -- "$run_command")
-readonly run_command run_command_base_name
+readonly run_command run_command_base_name=${run_command##*/}
 
 run_timestamp=$(date "+%Y%m%d_%H%M%S")
 readonly run_timestamp

diff --git a/bin/find-in-jars b/bin/find-in-jars
@@ -31,9 +31,7 @@
 #           var2=$(echo value1)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/rp b/bin/rp
@@ -12,9 +12,7 @@
 # @author Jerry Lee (oldratlee at gmail dot com)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/show-busy-java-threads b/bin/show-busy-java-threads
@@ -25,9 +25,7 @@
 #           local var2
 #           var2=$(echo value1)
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 # choosing between $0 and BASH_SOURCE
 # https://stackoverflow.com/a/35006505/922688

diff --git a/bin/taoc b/bin/taoc
@@ -11,9 +11,7 @@
 # @author Jerry Lee (oldratlee at gmail dot com)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/tcp-connection-state-counter b/bin/tcp-connection-state-counter
@@ -10,9 +10,7 @@
 # @author @sunuslee (sunuslee at gmail dot com)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/uq b/bin/uq
@@ -28,9 +28,7 @@
 #           var2=$(echo value1)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/bin/xpl b/bin/xpl
@@ -25,9 +25,7 @@
 #           var2=$(echo value1)
 set -eEuo pipefail
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG=$(basename -- "$0")
-readonly PROG
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 ################################################################################

diff --git a/legacy-bin/cp-svn-url b/legacy-bin/cp-svn-url
@@ -25,8 +25,7 @@
 #           local var2
 #           var2=$(echo value1)
 
-# NOTE: DO NOT declare var PROG as readonly in ONE line!
-PROG="$(basename -- "$0")"
+readonly PROG=${0##*/}
 readonly PROG_VERSION='2.x-dev'
 
 usage() {

diff --git a/legacy-bin/svn-merge-stop-on-copy b/legacy-bin/svn-merge-stop-on-copy
@@ -11,7 +11,7 @@
 # @author jiangjizhong(@jzwlqx)
 # @author Jerry Lee (oldratlee at gmail dot com)
 
-PROG="$(basename -- "$0")"
+readonly PROG=${0##*/}
 
 usage() {
   cat <<EOF