chore: fix empty favicon update (#451)

Co-authored-by: Ole Eskild Steensen <[email protected]>
oleeskild · Oct 1, 2023 · ab26117 · ab26117
1 parent 9d25440
commit ab26117
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/ui/SettingsView/SettingView.ts b/src/ui/SettingsView/SettingView.ts
@@ -781,9 +781,14 @@ export default class SettingView {
 
 			faviconsAreIdentical =
 				// @ts-expect-error TODO: abstract octokit response
-				currentFaviconOnSite.data.content
-					.replaceAll("\n", "")
-					.replaceAll(" ", "") === base64SettingsFaviconContent;
+				currentFaviconOnSite.data.content ===
+				base64SettingsFaviconContent;
+
+			if (faviconsAreIdentical) {
+				Logger.info("Favicons are identical, skipping update");
+
+				return;
+			}
 		} catch (error) {
 			faviconExists = false;
 		}