Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix garden on mobile #478

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: fix garden on mobile #478

merged 1 commit into from
Oct 12, 2023

Conversation

julesvirallinen
Copy link
Contributor

It seems main.ts had dotenv imported, which is probably what's breaking on mobile. Removes, as it isn't needed.

oleeskild
oleeskild reviewed Oct 11, 2023
View reviewed changes
Copy link
Owner

@oleeskild oleeskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mobile, so I can't check this properly, but aren't we using dotenv for variables when running npm run dev? Or is that retrieved from somewhere else? I can't remember on the the top of my head

@julesvirallinen
Copy link
Contributor Author

The dotenv things are in seperately run scripts. In obsidian we don't have the same env cuz were running inside obsidian

@oleeskild oleeskild merged commit 9687a3f into oleeskild:main Oct 12, 2023
4 checks passed
@oleeskild
Copy link
Owner

Releasing this as a beta version to test if it works, then as a normal release shortly after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleeskild oleeskild oleeskild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julesvirallinen @oleeskild