[propose] Allow better customization of individual chars

[jfromaniello]

This change is inspired by node.js's https://github.com/Automattic/cli-table which allows to configure more separator characters to allow the user to use a wider scope of ascii characters.

By default it still render as before and still has the same 3 methods for customizing the characters.

I am introducing a new method called SetSeparators() which receives an struct with all separators characters.

I am also exposing Themes.Default, Themes.CliTable, Themes.CliTableDouble.

Example with Themes.Default (or by not setting the separators):

+------------+-----------+---------+
| FIRST NAME | LAST NAME |   SSN   |
+------------+-----------+---------+
| John       | Barry     | 123456  |
+------------+-----------+---------+
| Kathy      | Smith     | 687987  |
+------------+-----------+---------+
| Bob        | McCornick | 3979870 |
+------------+-----------+---------+

Example with Themes.CliTable

┌────────────┬───────────┬─────────┐
│ FIRST NAME │ LAST NAME │   SSN   │
├────────────┼───────────┼─────────┤
│ John       │ Barry     │ 123456  │
│ Kathy      │ Smith     │ 687987  │
│ Bob        │ McCornick │ 3979870 │
└────────────┴───────────┴─────────┘

Example with Themes.CliTableDouble

╔════════════╤═══════════╤═════════╗
║ FIRST NAME │ LAST NAME │   SSN   ║
╟────────────┼───────────┼─────────╢
║ John       │ Barry     │ 123456  ║
║ Kathy      │ Smith     │ 687987  ║
║ Bob        │ McCornick │ 3979870 ║
╚════════════╧═══════════╧═════════╝

Example with table.SetSeparators(Themes.CliTable)and table.SetBorder(false):

  FIRST NAME │ LAST NAME │   SSN    
─────────────┼───────────┼──────────
  John       │ Barry     │ 123456   
  Kathy      │ Smith     │ 687987   
  Bob        │ McCornick │ 3979870  

[mattn]

Looks nice. Could you please rebase master?

[olekukonko]

ping @jfromaniello

[olekukonko]

A lot of modification has happened since this PR, @mattn should this be closed?

[mfridman]

This is such an awesome PR, would love to see this land. The CLI theme looks much cleaner.

Example:

+--------+---------+--------------------------------------------------+--------+------+------+------+
│ STATUS │ ELAPSED │                     PACKAGE                      │ COVER  │ PASS │ FAIL │ SKIP │
+--------+---------+--------------------------------------------------+--------+------+------+------+
│ PASS   │ 0.03s   │ github.com/mfridman/rover/pkg/paging/stringpager │ 100.0% │    3 │    0 │    0 │
│ PASS   │ 0.05s   │ github.com/mfridman/rover/tests                  │ 0.0%   │    5 │    0 │    0 │
│ PASS   │ 0.03s   │ github.com/mfridman/rover/tests/helper           │ 0.0%   │    1 │    0 │    0 │
+--------+---------+--------------------------------------------------+--------+------+------+------+

vs

┌────────┬─────────┬──────────────────────────────────────────────────┬────────┬──────┬──────┬──────┐
│ STATUS │ ELAPSED │                     PACKAGE                      │ COVER  │ PASS │ FAIL │ SKIP │
├────────┼─────────┼──────────────────────────────────────────────────┼────────┼──────┼──────┼──────┤
│ PASS   │ 0.03s   │ github.com/mfridman/rover/pkg/paging/stringpager │ 100.0% │    3 │    0 │    0 │
│ PASS   │ 0.05s   │ github.com/mfridman/rover/tests                  │ 0.0%   │    5 │    0 │    0 │
│ PASS   │ 0.03s   │ github.com/mfridman/rover/tests/helper           │ 0.0%   │    1 │    0 │    0 │
└────────┴─────────┴──────────────────────────────────────────────────┴────────┴──────┴──────┴──────┘

[jfromaniello]

Wow. I do not remember anything about this PR. I haven’t written code in golang for a while. I might have just copied a lot of code from the cli-table project as I mentioned in the request.

I am honestly not sure if I could be of any help.

[mfridman]

Thanks for putting this together all those years ago. Not sure how actively maintained this package is now, but if time permits I could offer to pick this up.

There is definitely value in allowing this to make the final tables look sharper.