Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add split k-mer analysis #27

Open
wants to merge 126 commits into
base: dev
Choose a base branch
from
Open

Add split k-mer analysis #27

wants to merge 126 commits into from

Conversation

olgabot
Copy link
Owner

@olgabot olgabot commented Jul 17, 2019

Many thanks to contributing to nf-core/kmer-similarity!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/kmer-similarity branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/kmer-similarity/tree/master/.github/CONTRIBUTING.md

olgabot added 30 commits July 1, 2019 14:34
@olgabot
Don't compute DNA if not specified
190d49f
@olgabot
Fix not_dna flag
ed6e87c
@olgabot
Update dockerfile to use olgabot/dayhoff branch"
46843fc
@olgabot
Don't install sourmash via conda for now because of version conflicts
e4ab6b9
@olgabot
Use olgabot/dayhoff tagged docker image
a688c6b
@olgabot
Use dash instead of slash in container name
d1fe3e5
@olgabot
Use olgabot/dayhoff tagged docker image
8faa0bc
@olgabot
Use olgabot-dayhoff version
c4739cd
@olgabot
Don't specify container in main.nf
589ce92
@olgabot
Put container name in nextflow.config
c4574be
@olgabot
Add summary section and single ended reads
c394f78
@olgabot
Use defulat optoins
80d3f31
@olgabot
Add test configuration
045dc49
@olgabot
Add more escaped slashes
10e3b1b
@olgabot
Add docs and changelog to make 'nf-core lint' happy
e22296b
@olgabot
demux --> nf-kmer-similarity
48f7b26
@olgabot
Add outputs for execution reports
6419235
@olgabot
Add date from initial commit
ee85dff
@olgabot
Don't lint for now
55054c7
@olgabot
Add .github folder
eec23be
@olgabot
Rename to nf-kmer-similarity
342294c
@olgabot
Allow PRs to master from anywhere
7e0b63a
@olgabot
Fix sample input processing
0fd88d3
@olgabot
Add comment about read_paths
902cb10
@olgabot
Add a bunch of documentatin
02760aa
@olgabot
Add default value for log2_sketch_size"
3b1ca28
@olgabot
Use dev tag on docker image (Makefile)
b629b89
@olgabot
Move timeline to later
d38a6a0
@olgabot
Use reorganizedd inputs
fd76e43
@olgabot
Re-add PRs to master only from dev restriction
2859209
@olgabot
Update readme with lots of info .. maybe should be in usage/docs.md ?
13c83ea
@olgabot
Add note about divisibility by 3
276e122
@olgabot
Add bash type and remove seqtk subsampling from first example
03316d9
@olgabot
Add a bunch more explanation about split kmers
bad3510
@olgabot
Add separate ska test configuration
d0314a4
@olgabot
Add note about PRs to dev
c3f07b0
@olgabot
Use nfcore/kmermaid container
5936a60
@olgabot
Add travis matrix to separate linting, etc
e2112e8
@olgabot
Remove 'env' section since this is now covered by the matrix
d872b9a
@olgabot
Add if statement to make exit code 0 to assert --splitKmer + molecule…
7476637 
…=protein did not work
@olgabot
Use --user to install with pip
41b9e1c
@olgabot
Add markdownlint
e0de975
@olgabot
Add test_ska config to git
8f99b31
@olgabot
Don't put if statement logic into FLAGS variableg
c8e3564
@olgabot
Add PR to dev on checklist
cf58ca1
@olgabot
'script' not under a dash
0ec026e
@olgabot
Can't use 'user' in this virtualenv??
952c46e
@olgabot
Organize output directories
c26c952
@olgabot
Fix markdownlint
61892ef
@olgabot
Separate out ska and sourmash outputs
a0af972
@olgabot
Add ska to environment.yml'
c72ef56
@olgabot
Update changelog with ska, seqtk
be04112
@olgabot
Merge pull request #11 from nf-core/olgabot/add-ska-to-container
f03dd69 
Olgabot/add ska to container
@olgabot
Merge branch 'dev' into olgabot/split-kmer
622116d
@olgabot
Add ska subsampling to test suite
7767621
@olgabot
Markdownlint fixes
9d77643
@olgabot
Whitespace and capitalize
54331bd
@olgabot
Add java version back to minimum nextflow version
94e4ad7
@olgabot
Remove nf-core/tools install from non-linting stuff
fbc2556
@pranathivemuri pranathivemuri mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgabot @phoenixAja