Start v05 #110
Closed
Start v05 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts on version 0.5 by copy/pasting the code and tests from v04 to new directories. I ummed and ahhed about whether this was the best approach, but I think it is - the other alternative is importing from the v04 namespace, which would be tricky to implement, and also I think more prone to error than doing a simple copy/paste of the whole sub-module.
I will leave this PR open for a little bit to see if anyone has suggestions for a better alternative?
Note that this doesn't actually implement any of the v05 spec - that's for subsequent PRs 😄