Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Maven profiles to handle different versions of TestNG #36

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 6, 2024

Superseded #24 - see also ome/ome-common-java#88

For JDK8, bump org.testng:testng to the last supported release for this version i.e. 7.5
For JDK11+, bump org.testng:testng to the latest release 7.9.0

For JDK8, bump org.testng:testng to the last supported release for
this version i.e. 7.5
For JDK11+, bump org.testng:testng to the latest release 7.9.0
@sbesson
Copy link
Member Author

sbesson commented Mar 6, 2024

@melissalinkert in https://github.com/ome/bioformats, I noticed that org.testng:testng is declared as a dependency for each component and the version of the dependency is declared the properties tag in the top-level POM.

Rather than duplicating the profile code for each component, 9b981f8 explores an option to maintain this semantics and make the value of testng.version profile-activated depending on the JDK version. I'll wait to hear your thoughts before opening a similar change against Bio-Formats

Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting just testng.version based on the profile makes sense to me, especially in ome/bioformats.

I'm fine with either this or the approach in ome/ome-common-java#88 for the low-level repositories, though, so totally up to you if want to leave the other similar pull requests as-is or use the version property approach across the board.

@sbesson sbesson merged commit d8be317 into ome:master Mar 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants