Only declare logback-classic as a runtime dependency #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means logback-core is managed as a transitive dependency of logback-classic and the compatible version is resolved through the dependency mechanism rather than being manually managed.
melissalinkert
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Comparing the output of mvn dependency:tree, without this change I see:
[INFO] +- ch.qos.logback:logback-core:jar:1.3.14:compile (optional)
[INFO] +- ch.qos.logback:logback-classic:jar:1.3.14:compile (optional)
and with this change I see:
[INFO] +- ch.qos.logback:logback-classic:jar:1.3.14:compile (optional)
[INFO] | \- ch.qos.logback:logback-core:jar:1.3.14:compile (optional)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current POM, logback-core and logback-classic and declared separately and bumped individually by the dependabot agent. This can be an issue for logback releases including backwards-incompatible API changes. This was the case in #93 and more recently in #94 where the GitHub Actions tests failed due to the backported removal of
JaninoEventEvaluatorin 1.3.15.Given the strong coupling of
logback-coreandlogback-classic, 0a4140f removes the declaration oflogback-corefrompom.xml. The version should now be resolved as a transitive dependency oflogback-classic.