Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build #92

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Build #92

merged 5 commits into from
Dec 16, 2024

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 20, 2024

Update actions and Update PyPI publish workflow to use build instead of sdist

@erickmartins
Copy link
Collaborator

This seems to have broken the majority of the tests - looks like a pydantic/ome-types issue, and it's unclear to me why this change would modify that behavior at all!

@jburel
Copy link
Member Author

jburel commented Dec 15, 2024

@erickmartins build is now green

@jburel jburel requested a review from erickmartins December 15, 2024 20:08
@erickmartins
Copy link
Collaborator

This looks reasonable, but unfortunately I won't be able to fully test it until we're releasing a new version - at which point I might come back to bother you with questions, @jburel :)

@jburel
Copy link
Member Author

jburel commented Dec 16, 2024

The release steps have been validated in other repositories.
The main point in this PR was the change for the testing job

@erickmartins erickmartins merged commit 360b535 into ome:main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants