-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorbar feature #605
base: master
Are you sure you want to change the base?
Colorbar feature #605
Conversation
… adding inverting of colorbar
… adding inverting of colorbar
this.render(); | ||
}); | ||
this.loadLuts(); | ||
this.render(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change now calls this.render()
before the luts have loaded. Haven't tested to see if this actually causes a bug, but I think this will be fixed with:
this.loadLuts().then(() => this.render());
I wonder if you want to allow users to choose the channel for the colorbar (if you have more than one active)? It's even possible to imagine someone wanting 2 or more colorbars at once, for different channels, but I guess that's a bit edge case (you would just do a split-view figure). |
This PR implements the optional display of a colorbar next to a panel. The colorbar shows the mapping between pixel values and LUT ("normal" color included). This is work from @MinaEnayat and me.
There are still adjustments to be made, but this is functional and mature enough that we thought it was ready to receive comments/ideas.
Implemented features:
A spine with the ticks and labels gives a visual clue when the LUT is the same color as the page background, but only on one side to avoid confusion with the LUT when the LUT is the same color as the spine:
Suggestions for tests:
Known issues / work left:
-log10(end-start / num_ticks)