improved mirroring #484
improved mirroring #484
Conversation
|
Thanks for this - apologies for the delayed response. NB: I also found it a little tricky to know when the image was flipped as there's no indicator. This is outside the scope of the PR so no need to address it now unless you want to, e.g. add some visual clue to the flip buttons when they are enabled? |
|
That's strange... I added a mitigation specifically to fix that on my end line 80 |
|
That's weird. I'm building with |
|
added flip indicator, not pretty lol but distinct between flipped and not flipped. |
|
Think I might have gotten it figured out? I was looking at the name of the constructor which gets minified in prod. Hopefully that was it, I don't have an easy way of testing this out, let me know if it's still an issue then I'll set up a proper dev environment to test this more thoroughly. |
There was a problem hiding this comment.
That's fixed it - thanks!
Looking good - approved.
I noticed one tiny issue which I'll mention in case you can find a fix (but isn't a blocker on this PR which already has plenty of fixes)... The blue rectangle that appears when you hold Command-drag to select a bunch of ROIs is flipped on the screen (although the ROIs are correctly selected from the area that was actually dragged over).
|
Great catch! Thanks! (didn't know you could do that lol) It's mostly fixed. It captures extents properly but for whatever reason it doesn't render when only X is mirrored. When just Y or X and Y are mirrored it works perfectly but X is misbehaving. Still captures properly so I think it's better than it was. |
|
Still haven't figured out roi popups yet. I'll skip that this PR, but if there's anything else you find, let me know. Thanks! |
|
Hello, A few things that I spotted. When you click a button, it stays selected until something elsewhere is clicked. I find it slightly annoying. It would be nice if it could keep the "unselected" look right after clicking on it. About the button color, I tried with different blues. I could suggest the "dodgerblue". To finish, I found an actual bug: the text of the label ROIs are flipped too 😅 Cheers, |
|
@Tom-TBT Thanks a lot! I appreciate it! I like the color change, I'll add that. I was aware of the other two issues, the button thing is just weird and the text thing seems tricky, but I'll take a peak. The button issue can probably get solved, but the text issue seems like it will need the proper projection based flipping to keep the position accurate while displaying the text right side up, although I'll take a stab at it. |
|
Sorry for the delay. Changed the color but I don't think I'll be able to fix the text issue or the selected issue. The text is ol native, so I'm not sure how to go about extending or modifying that and the selected issue seems to effect all the controls, such as zoom and birdseye, even on the IDR. I created #487 to track it. |
|
Just discovered that the scalebar can be dragged, and of course, it drags wrong when flipped, checking it out now. |
|
Sorry, got busy and this fell off, won't be able to put time into this for a bit. I think this is a good place to call it for this pr. |
|
This contains a bunch of fixes so it would be good to get this in. |
Fixed the jitter from panning while rotated, and it seems at some point in the pr process drawing the rois while mirrored broke. Fixed it up. Still couldn't get projections to work. I do think that would be the most robust way to handle this but I'll take another crack at projections next time something breaks. Thanks y'all!