Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handling makes sense. An alternative would be to store and return
self._gridSize = None
. In case the wells are being added in between calls, this would allow subsequent calls toself.getGridSize()
to retry the plate query. I do not know enough about consumers of this API and how aNone
return value would be handled.Either way, it's probably good practice to update the docstring and document the expectation in case the plate has no wells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbesson - apologies for the delay...
I think the expectation is not to return
None
- Returning sizes of0
is more consistent and doesn't need special handling ofNone
by consumers.Docstring updated.