Xn Handover - AMF crash fix #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thakurajayL
reviewed
Sep 23, 2024
| // Check if the smContext is nil to prevent nil pointer dereference | ||
| if smContext == nil { | ||
| return nil, nil, nil, fmt.Errorf("smContext is nil") | ||
| } |
There was a problem hiding this comment.
What was the outcome of the Xn handover after this fix?
There was a problem hiding this comment.
Before this fix, if the PDU session ID was invalid, the AMF would crash. However, after this fix, the AMF properly sends a Path Switch Request Failure to the gNodeB. You can verify this by checking the AMF logs and PCAPs.
Signed-off-by: Jayaram R <[email protected]>
gab-arrobo
force-pushed
the
xn-handover-nil-ptr
branch
from
ed9b975
to
00b3339
Compare
thakurajayL
approved these changes
Sep 27, 2024
mbilal92
pushed a commit
to mbilal92/amf
that referenced
this pull request
Sep 27, 2024
…#306) Signed-off-by: Jayaram R <[email protected]> Co-authored-by: Ajay Lotan Thakur <[email protected]> Signed-off-by: Bilal Saleem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Xn Handover failure due to AMF crashing when the gNodeB provides an incorrect PDU Session ID in the NG Path Switch Request.
Troubleshoot:
The crash was traced to the absence of a proper check for the PDU Session ID in the SendUpdateSmContextXnHandover function, causing the AMF to crash when receiving an incorrect or invalid PDU Session ID from the gNodeB.
Fix:
The issue has been resolved by adding a nil check in the SendUpdateSmContextXnHandover function.
Supporting Data:
Xn-Handover-AMF-Crash-PCAP-Logs.zip