fix: o.o.c.segmentation.SRX to load conf and save srx in more robust way and remove warning message #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
changed the title
miurahr
force-pushed
the
topic/miurahr/srx/unkown-langauge-error
branch
from
f6951c9
to
c0defb6
Compare
miurahr
changed the title
|
There are two test failures.
|
miurahr
force-pushed
the
topic/miurahr/srx/unkown-langauge-error
branch
2 times, most recently
from
176fa88
to
16ab78e
Compare
miurahr
force-pushed
the
topic/miurahr/srx/unkown-langauge-error
branch
from
cda89d4
to
6cae905
Compare
- reafactor SRXTest class - Add germany locale conf file built from OmegaT 5.4.0 as test data - refactor SRX class to help testing - Load resource bundle in specified test locale Signed-off-by: Hiroshi Miura <[email protected]>
- Harden the save method to robust for localized language name. - Even when MapRule has a localized language code, it detects language from a language pattern and write standard name. Signed-off-by: Hiroshi Miura <[email protected]>
- rulename for text in Germany was changed in v5.5 - when reading "segmentation.conf" generated before v5.4, migration is failed. - Add workaround to detect ancient rulename Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/srx/unkown-langauge-error
branch
from
6cae905
to
a69a418
Compare
miurahr
commented
Nov 2, 2024
| /** Language Name */ | ||
| private String languageCode; | ||
|
|
||
| public MapRule(Languagemap languagemap, List<Rule> rules) { |
There was a problem hiding this comment.
I removed the ctor with Languagemap as argument. It reduces a dependency of classes. A retrieval of fields of languagemap is done in the caller.
| public MapRule(String language, String pattern, List<Rule> rules) { | ||
| this.setLanguage(language); | ||
| String code = LanguageCodes.getLanguageCodeByPattern(pattern); | ||
| this.setLanguage(code != null ? code : language); |
There was a problem hiding this comment.
We got language from the pattern, if it got "EN.*" as pattern we can know it is for English.
Use non localized message for debug level
- Update LanguageCode.getLanguageCodeByName
- add null check at first
- move a migration heuristics code from MapRule
- Update MapRule javadoc descriptions
Signed-off-by: Hiroshi Miura <[email protected]>
Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
commented
Nov 2, 2024
| public static class SRXMigrateJaTest { | ||
|
|
||
| @org.junit.Rule | ||
| public final LocaleRule localeRule = new LocaleRule(new Locale("ja")); |
There was a problem hiding this comment.
This is a hack to change System Locale to run unit test cases.
Because LocaleRule utility class is not related to the OmegaT functions, please ignore it if you don't know.
miurahr
changed the title
Signed-off-by: Hiroshi Miura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Which ticket is resolved?
What does this PR change?
Other information
#1158