-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce matchSource match template variable #1220
Open
miurahr
wants to merge
10
commits into
master
Choose a base branch
from
topic/miurahr/introduce-match-source-match-template-variable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
53854ed
feat: introduce matchSource match template variable
miurahr 6452974
chore: update checkstyle suppressions
miurahr 7df4e20
style: MatchesVarExpansion spacing
miurahr dca4639
docs: Update NearString javadoc
miurahr 078aacf
style: update checkstyle suppressions.xml
miurahr 7fffdf0
fix: update bundle key and string to adjust for review feedback
miurahr 3704d44
Merge branch 'master' into topic/miurahr/introduce-match-source-match…
miurahr 4db0ff1
fix: update acceptance test expectation
miurahr e9db7fb
Apply suggestions from code review
miurahr 8cf99d0
Apply suggestions from code review
miurahr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -90,19 +90,21 @@ public class MatchesVarExpansion extends VarExpansion<NearString> { | |||||
public static final String VAR_DIFF_REVERSED = "${diffReversed}"; | ||||||
public static final String VAR_SOURCE_LANGUAGE = "${sourceLanguage}"; | ||||||
public static final String VAR_TARGET_LANGUAGE = "${targetLanguage}"; | ||||||
public static final String VAR_MATCH_SOURCE = "${matchSource}"; | ||||||
|
||||||
private static final String[] MATCHES_VARIABLES = { VAR_ID, VAR_SOURCE_TEXT, VAR_DIFF, VAR_DIFF_REVERSED, | ||||||
VAR_TARGET_TEXT, VAR_SCORE_BASE, VAR_SCORE_NOSTEM, VAR_SCORE_ADJUSTED, VAR_FILE_NAME_ONLY, | ||||||
VAR_FILE_PATH, VAR_FILE_SHORT_PATH, VAR_INITIAL_CREATION_ID, VAR_INITIAL_CREATION_DATE, | ||||||
VAR_CHANGED_ID, VAR_CHANGED_DATE, VAR_FUZZY_FLAG, VAR_SOURCE_LANGUAGE, VAR_TARGET_LANGUAGE }; | ||||||
VAR_CHANGED_ID, VAR_CHANGED_DATE, VAR_FUZZY_FLAG, VAR_SOURCE_LANGUAGE, VAR_TARGET_LANGUAGE, | ||||||
VAR_MATCH_SOURCE }; | ||||||
|
||||||
public static List<String> getMatchesVariables() { | ||||||
return Collections.unmodifiableList(Arrays.asList(MATCHES_VARIABLES)); | ||||||
} | ||||||
|
||||||
public static final String DEFAULT_TEMPLATE = VAR_ID + ". " + VAR_FUZZY_FLAG + VAR_SOURCE_TEXT + "\n" | ||||||
+ VAR_TARGET_TEXT + "\n" + "<" + VAR_SCORE_BASE + "/" + VAR_SCORE_NOSTEM + "/" | ||||||
+ VAR_SCORE_ADJUSTED + "% " + VAR_FILE_PATH + ">"; | ||||||
+ VAR_SCORE_ADJUSTED + "%" + VAR_MATCH_SOURCE + VAR_FILE_PATH + ">"; | ||||||
|
||||||
public static final Pattern PATTERN_SINGLE_PROPERTY = Pattern.compile("@\\{(.+?)\\}"); | ||||||
public static final Pattern PATTERN_PROPERTY_GROUP = Pattern | ||||||
|
@@ -222,6 +224,22 @@ private String getPropValue(List<TMXProp> props, String type) { | |||||
return null; | ||||||
} | ||||||
|
||||||
private String expandMatchSource(String localTemplate, NearString.MATCH_SOURCE comesFrom) { | ||||||
switch (comesFrom) { | ||||||
case TM: | ||||||
return localTemplate.replace(VAR_MATCH_SOURCE, OStrings.getString("MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_TM") + " "); | ||||||
case FILES: | ||||||
return localTemplate.replace(VAR_MATCH_SOURCE, OStrings.getString("MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_FILES")); | ||||||
case MEMORY: | ||||||
return localTemplate.replace(VAR_MATCH_SOURCE, OStrings.getString("MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_MEMORY")); | ||||||
case SUBSEGMENTS: | ||||||
return localTemplate.replace(VAR_MATCH_SOURCE, OStrings.getString( | ||||||
"MATCHES_VAR_EXPANSION_MATCH_COMES_FROM_TM_SUBSEG") + " "); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
default: | ||||||
return localTemplate.replace(VAR_MATCH_SOURCE, ""); | ||||||
} | ||||||
} | ||||||
|
||||||
@Override | ||||||
public String expandVariables(NearString match) { | ||||||
// do not modify template directly, so that we can reuse for another | ||||||
|
@@ -285,6 +303,9 @@ public String expandVariables(NearString match) { | |||||
} else { | ||||||
localTemplate = localTemplate.replace(VAR_TARGET_TEXT, match.translation); | ||||||
} | ||||||
|
||||||
localTemplate = expandMatchSource(localTemplate, match.comesFrom); | ||||||
|
||||||
return localTemplate; | ||||||
} | ||||||
|
||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.