refactor(filters4): XLIFF1,2 filters and abstract classes #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unnecessary static for eFactory - Unnecessary silent override of eFactory - Unnecessary nested blocks - Bad style of commenting in if-elseif syntax - Unnecessary static for toPair method Signed-off-by: Hiroshi Miura <[email protected]>
miurahr
force-pushed
the
topic/miurahr/filters4/refactor-stax-filters-try-resource-more
branch
from
250b710 to
ced8b0b
Compare
|
@t-cordonnier please check the changes are not harm for features? |
|
Tested with a few documents no difference found |
miurahr
deleted the
topic/miurahr/filters4/refactor-stax-filters-try-resource-more
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many code style warnings/errors on StaX filters.
The changes here to resolve the style errors.
These style errors has been introduced when accepting filters, all checkstyle errors are treated as warning, and author and reviewer does not aware of it.
Pull request type
What does this PR change?
eFactoryfieldeFactoryif-elseifsyntaxtoPairmethodtry-resourceinAbstractZipFilterOther information