Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Excel OpenSpout exporter #332

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

mhvis
Copy link
Contributor

@mhvis mhvis commented Mar 5, 2024

PhpSpreadsheet is not very performant for larger files. Here is a suggestion to add OpenSpout as an additional exporter. It performs ~40x faster in my test setup.

HTML tags are stripped from the input data because there is no rich text support in OpenSpout.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (668e7bd) to head (4754054).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #332   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          36       36           
  Lines         956      956           
=======================================
  Hits          903      903           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curry684
Copy link
Member

curry684 commented Mar 6, 2024

Looks good, thanks 👍

@curry684 curry684 merged commit 879898d into omines:master Mar 6, 2024
11 checks passed
@curry684
Copy link
Member

Published as well now, sorry.

@mhvis
Copy link
Contributor Author

mhvis commented Mar 25, 2024

Thanks very much!

@mhvis mhvis deleted the maarten-openspout2 branch September 19, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants