Fixed null pointer error when trying to get the login info (#313)

omkarmoghe · Jul 29, 2016 · 0b8ad2c · 0b8ad2c
1 parent d049833
commit 0b8ad2c
Showing 1 changed file with 21 additions and 16 deletions.
diff --git a/...ain/java/com/omkarmoghe/pokemap/controllers/app_preferences/PokemapSharedPreferences.java b/...ain/java/com/omkarmoghe/pokemap/controllers/app_preferences/PokemapSharedPreferences.java
@@ -4,6 +4,7 @@
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
 import android.support.annotation.NonNull;
+import android.text.TextUtils;
 import android.util.ArraySet;
 import android.util.Log;
 
@@ -63,16 +64,18 @@ public LoginInfo getLoginInfo() {
                 String password = null;
 
                 for (String s :info) {
-                    if(s.contains(INFO_TOKEN)){
-                        token = getStoredString(s);
-                        continue;
-                    }
-                    if(s.contains(INFO_USERNAME)){
-                        username = getStoredString(s);
-                        continue;
-                    }
-                    if(s.contains(INFO_PASSWORD)){
-                        password = getStoredString(s);
+                    if(!TextUtils.isEmpty(s)) {
+                        if (s.contains(INFO_TOKEN)) {
+                            token = getStoredString(s);
+                            continue;
+                        }
+                        if (s.contains(INFO_USERNAME)) {
+                            username = getStoredString(s);
+                            continue;
+                        }
+                        if (s.contains(INFO_PASSWORD)) {
+                            password = getStoredString(s);
+                        }
                     }
                 }
                 return new PtcLoginInfo(token, username, password);
@@ -88,12 +91,14 @@ public LoginInfo getLoginInfo() {
                 String refresh = null;
 
                 for (String s :info) {
-                    if(s.contains(INFO_TOKEN)){
-                        token = getStoredString(s);
-                        continue;
-                    }
-                    if(s.contains(INFO_PASSWORD)){
-                        refresh = getStoredString(s);
+                    if(!TextUtils.isEmpty(s)) {
+                        if (s.contains(INFO_TOKEN)) {
+                            token = getStoredString(s);
+                            continue;
+                        }
+                        if (s.contains(INFO_PASSWORD)) {
+                            refresh = getStoredString(s);
+                        }
                     }
                 }