Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Re-enable offsetParent and fix in webui's paper-tooltip"
This reverts commit def5070. Reason for revert: The polyfill I wrote, not the actual offsetParent flag, broke something else. I'll need to figure out what I did wrong in the polyfill and fix it in a reland: crbug.com/1264786 Fixed: 1264786 Original change's description: > Re-enable offsetParent and fix in webui's paper-tooltip > > When I first changed the behavior of offsetParent for crbug.com/920069 > it broke some webui pages which used paper-toolip: crbug.com/1200750 > > I minimized the broken case and determined that paper-tooltip was > broken. I made a PR on paper-tooltip here, but it's unlikely that it > will ever get merged: > PolymerElements/paper-tooltip#156 > > The fix to paper-tooltip is to polyfill the old offsetParent behavior in > javascript. This patch applies the fix to paper-tooltip within chrome > and re-enables the new offsetParent behavior. > > Fixed: 920069 > Change-Id: Ib39c34a6c15b44161a7942c7ee9cfd4afe68acf7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3061435 > Commit-Queue: Joey Arhar <[email protected]> > Reviewed-by: dpapad <[email protected]> > Cr-Commit-Position: refs/heads/main@{#935992} (cherry picked from commit 5c36b4e) Change-Id: I27faaeb162a004130e4692595530ea5ab4300574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3280437 Reviewed-by: Joey Arhar <[email protected]> Reviewed-by: dpapad <[email protected]> Auto-Submit: Joey Arhar <[email protected]> Commit-Queue: dpapad <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#941603} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282903 Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/branch-heads/4692@{chromium#200} Cr-Branched-From: 038cd96-refs/heads/main@{#938553}
- Loading branch information