Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain fine location and nearby devices permission requests #78

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Sep 4, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes failure to pair during initial P2P request experienced on devices running Android 13 and above reported here

This is an enhancement to Request for NEARBY_WIFI_DEVICES permission for Android 13 and higher

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Release | Other)

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide

Add null check for wifiP2pChannel when requesting device info
@Rkareko Rkareko self-assigned this Sep 4, 2024
@Rkareko Rkareko added DNM Do Not Merge and removed DNM Do Not Merge labels Sep 4, 2024
Copy link
Contributor

@ndegwamartin ndegwamartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a failing unit test

@Rkareko
Copy link
Contributor Author

Rkareko commented Sep 13, 2024

There's a failing unit test

@ndegwamartin This test is passing locally, however it's failing on CI. The fix will be tracked under this ticket as part of tech debt.

@Rkareko Rkareko merged commit 4bbb292 into main Sep 13, 2024
2 checks passed
@Rkareko Rkareko deleted the initial-pairing-failure-android-13 branch September 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants