Skip to content

Commit

Permalink
Wrap commodity edit in rbaccheck
Browse files Browse the repository at this point in the history
  • Loading branch information
@peterMuriuki
peterMuriuki committed Feb 16, 2024
1 parent 4a736b2 commit 23834ca
Show file tree
Hide file tree
Showing 2 changed files with 89 additions and 4 deletions.
13 changes: 9 additions & 4 deletions packages/fhir-group-management/src/components/CommodityList/Default/List.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import {
sendInfoNotification,
sendSuccessNotification,
} from '@opensrp/notifications';
import { useUserRole } from '@opensrp/rbac';
import { RbacCheck, useUserRole } from '@opensrp/rbac';

export interface GroupListProps {
fhirBaseURL: string;
Expand Down Expand Up @@ -156,9 +156,14 @@ export const DefaultCommodityList = (props: GroupListProps) => {
// eslint-disable-next-line react/display-name
render: (_: unknown, record: TableData) => (
<span className="d-flex align-items-center">
<Link to={`${ADD_EDIT_COMMODITY_URL}/${record.id}`} className="m-0 p-1">
{t('Edit')}
</Link>
<RbacCheck permissions={['Group.update']}>
<>
<Link to={`${ADD_EDIT_COMMODITY_URL}/${record.id}`} className="m-0 p-1">
{t('Edit')}
</Link>
<Divider type="vertical" />
</>
</RbacCheck>
<Divider type="vertical" />
<Dropdown
menu={{ items: getItems(record) }}
Expand Down
80 changes: 80 additions & 0 deletions ...up-management/src/components/CommodityList/Default/tests/__snapshots__/list.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ exports[`renders correctly when listing resources: table row 1 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -190,6 +194,10 @@ exports[`renders correctly when listing resources: table row 2 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -256,6 +264,10 @@ exports[`renders correctly when listing resources: table row 3 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -322,6 +334,10 @@ exports[`renders correctly when listing resources: table row 4 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -388,6 +404,10 @@ exports[`renders correctly when listing resources: table row 5 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -454,6 +474,10 @@ exports[`renders correctly when listing resources: table row 6 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -520,6 +544,10 @@ exports[`renders correctly when listing resources: table row 7 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -586,6 +614,10 @@ exports[`renders correctly when listing resources: table row 8 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -652,6 +684,10 @@ exports[`renders correctly when listing resources: table row 9 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -718,6 +754,10 @@ exports[`renders correctly when listing resources: table row 10 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -784,6 +824,10 @@ exports[`renders correctly when listing resources: table row 11 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -850,6 +894,10 @@ exports[`renders correctly when listing resources: table row 12 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -916,6 +964,10 @@ exports[`renders correctly when listing resources: table row 13 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -982,6 +1034,10 @@ exports[`renders correctly when listing resources: table row 14 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -1048,6 +1104,10 @@ exports[`renders correctly when listing resources: table row 15 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -1114,6 +1174,10 @@ exports[`renders correctly when listing resources: table row 16 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -1180,6 +1244,10 @@ exports[`renders correctly when listing resources: table row 17 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -1246,6 +1314,10 @@ exports[`renders correctly when listing resources: table row 18 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -1312,6 +1384,10 @@ exports[`renders correctly when listing resources: table row 19 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down Expand Up @@ -1378,6 +1454,10 @@ exports[`renders correctly when listing resources: table row 20 page 1 4`] = `
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<div
class="ant-divider css-dev-only-do-not-override-k7429z ant-divider-vertical"
role="separator"
/>
<span
aria-label="more"
class="anticon anticon-more ant-dropdown-trigger more-options"
Expand Down

0 comments on commit 23834ca

Please sign in to comment.