Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify buttons look in the application #1227

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Conversation

mutuajames
Copy link
Contributor

This removes the nesting of buttons and links which were invalid HTML. The solution is to either use one or the other depending on what is required.
closes #1222

@codecov-commenter
Copy link

Codecov Report

Merging #1227 (5e462ec) into master (641ece4) will decrease coverage by 0.29%.
The diff coverage is 45.83%.

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
- Coverage   95.05%   94.77%   -0.29%     
==========================================
  Files         321      322       +1     
  Lines        9389     9429      +40     
  Branches     2034     2034              
==========================================
+ Hits         8925     8936      +11     
- Misses        456      485      +29     
  Partials        8        8              
Impacted Files Coverage Δ
app/src/containers/pages/Home/Home.tsx 94.73% <ø> (ø)
...mponents/PatientDetails/ResourceSchema/Patient.tsx 100.00% <ø> (ø)
...-management/src/components/CommodityList/index.tsx 95.34% <ø> (ø)
...roup-management/src/components/GroupList/index.tsx 92.00% <0.00%> (-3.84%) ⬇️
...agement/src/components/UserList/ListView/index.tsx 97.77% <0.00%> (-2.23%) ⬇️
.../src/components/UserList/ListView/tableColumns.tsx 96.15% <ø> (ø)
...nagement/src/components/LocationUnitList/Table.tsx 100.00% <ø> (ø)
...ackages/fhir-views/src/QuestionnaireList/index.tsx 100.00% <ø> (ø)
...tory/src/components/PreConfirmationError/index.tsx 100.00% <ø> (ø)
...ent/src/components/LocationUnitGroupList/Table.tsx 93.75% <ø> (ø)
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@machariamuguku machariamuguku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mutuajames mutuajames merged commit d9633c6 into master Jul 11, 2023
2 checks passed
@mutuajames mutuajames deleted the 1222-unify-buttons-look branch July 11, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify the look for buttons in the whole app
3 participants