Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credentials redirect url #1258

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

peterMuriuki
Copy link
Collaborator

@peterMuriuki peterMuriuki commented Sep 8, 2023

close #1254

Fix url used to redirect to the credentials view.

  • Add username to urls that should redirect to credentials view
  • Add a create user test that also checks that final redirection to credentials view is valid

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #1258 (181e5d5) into master (b29146f) will increase coverage by 0.14%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1258      +/-   ##
==========================================
+ Coverage   92.96%   93.11%   +0.14%     
==========================================
  Files         201      201              
  Lines        5519     5521       +2     
  Branches     1212     1212              
==========================================
+ Hits         5131     5141      +10     
+ Misses        382      374       -8     
  Partials        6        6              
Files Changed Coverage Δ
...ent/src/components/UserList/TableActions/index.tsx 94.11% <0.00%> (ø)
...management/src/components/CreateEditUser/index.tsx 95.60% <100.00%> (+8.93%) ⬆️
...management/src/components/forms/UserForm/utils.tsx 89.62% <100.00%> (+0.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@peterMuriuki peterMuriuki enabled auto-merge (squash) September 8, 2023 15:39
@peterMuriuki peterMuriuki force-pushed the 1254-fix-credentials-redirect-url branch from 181e5d5 to 08bcaa8 Compare September 8, 2023 17:04
@peterMuriuki peterMuriuki merged commit e5d206a into master Sep 8, 2023
1 of 2 checks passed
@peterMuriuki peterMuriuki deleted the 1254-fix-credentials-redirect-url branch September 8, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Creating a user works as expected but after adding one is redirected to a 404 page error
3 participants