Skip to content

Commit

Permalink
fix failing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kelvin-muchiri committed Oct 1, 2024
1 parent dfeb6d0 commit c955431
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions onadata/apps/api/tests/viewsets/test_xform_viewset.py
Original file line number Diff line number Diff line change
Expand Up @@ -3977,7 +3977,7 @@ def test_csv_export_with_win_excel_utf8(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
_, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')
# sort csv data in ascending order
data = {"win_excel_utf8": False}
request = self.factory.get("/", data=data, **self.extra)
Expand All @@ -4002,7 +4002,7 @@ def test_csv_export_with_win_excel_utf8(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

@flaky
def test_csv_export_with_and_without_include_hxl(self):
Expand Down Expand Up @@ -4067,7 +4067,7 @@ def test_csv_export_with_and_without_include_hxl(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

request = self.factory.get("/", **self.extra)
response = view(request, pk=self.xform.pk, format="csv")
Expand All @@ -4090,7 +4090,7 @@ def test_csv_export_with_and_without_include_hxl(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

def test_csv_export__with_and_without_group_delimiter(self):
with HTTMock(enketo_mock):
Expand Down Expand Up @@ -4124,7 +4124,7 @@ def test_csv_export__with_and_without_group_delimiter(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

content = get_response_content(response)
content_header_row_with_slashes = content.split("\n")[0]
Expand All @@ -4139,7 +4139,7 @@ def test_csv_export__with_and_without_group_delimiter(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

content = get_response_content(response)
content_header_row_with_dots = content.split("\n")[0]
Expand Down Expand Up @@ -4186,7 +4186,7 @@ def test_csv_export__with_and_without_do_not_split_select_multiples(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

content = get_response_content(response)
content_header_row_select_multiple_split = content.split("\n")[0]
Expand All @@ -4204,7 +4204,7 @@ def test_csv_export__with_and_without_do_not_split_select_multiples(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

content = get_response_content(response)
content_header_row_select_multiple_not_split = content.split("\n")[0]
Expand Down Expand Up @@ -4250,7 +4250,7 @@ def test_csv_export_with_and_without_removed_group_name(self):
filename = filename_from_disposition(content_disposition)
self.assertIn(GROUPNAME_REMOVED_FLAG, filename)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

expected_data = ["n/a"]
key = "available_transportation_types_to_referral_facility_other" # noqa
Expand All @@ -4266,7 +4266,7 @@ def test_csv_export_with_and_without_removed_group_name(self):
filename = filename_from_disposition(content_disposition)
self.assertNotIn(GROUPNAME_REMOVED_FLAG, filename)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

expected_data = ["n/a"]
key = "transport/available_transportation_types_to_referral_facility_other" # noqa
Expand Down Expand Up @@ -4307,7 +4307,7 @@ def test_csv_export_no_new_generated(self):
filename = filename_from_disposition(content_disposition)
self.assertNotIn(GROUPNAME_REMOVED_FLAG, filename)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

request = self.factory.get("/", **self.extra)
response = view(request, pk=self.xform.pk, format="csv")
Expand All @@ -4322,7 +4322,7 @@ def test_csv_export_no_new_generated(self):
filename = filename_from_disposition(content_disposition)
self.assertNotIn(GROUPNAME_REMOVED_FLAG, filename)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

def test_xform_linked_dataviews(self):
xlsform_path = os.path.join(
Expand Down Expand Up @@ -4513,7 +4513,7 @@ def _validate_csv_export(
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

content = get_response_content(response)

Expand Down Expand Up @@ -4990,7 +4990,7 @@ def test_csv_export_with_meta_perms(self):
content_disposition = headers["Content-Disposition"]
filename = filename_from_disposition(content_disposition)
basename, ext = os.path.splitext(filename)
self.assertEqual(ext, ".csv")
self.assertEqual(ext, '.csv"')

expected_data = ["alice", "alice"]
key = "_submitted_by"
Expand Down

0 comments on commit c955431

Please sign in to comment.